Change how we get packages off the raid. #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have frequent intermittent failures where the Nuget packages are corrupted in some fashion. What we currently do is for each sample build and point our source of Nuget packages at the location on the raid. I think this is part of the problem, when there's an intermittent hiccup or conflict with what's on the raid. Instead, let's first copy the packages of interest locally. Then we'll use that as our source to point at. Also, refactor to remove some redundancy. This should lead to some performance improvement because now we no longer are dependent on constantly asking dotnet to look at the raid for each sample's build, we just look at the raid once to get what we need and then are local again.
datalogics-josepha
force-pushed
the
build-change
branch
from
88fc0a7 to
59fa6c9
Compare
|
Looking at the changes. I'm making the assumption that packages to that local directory would get overriden in re-runs. What about when we move to new versions of packages, would that local directory keep all of the previous versions of the packages? |
|
I think we should be ok in that case, because the |
datalogics-aarroyo
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have frequent intermittent failures where the Nuget packages are corrupted in some fashion. What we currently do is for each sample build and point our source of Nuget packages at the location on the raid.
I think this is part of the problem, when there's an intermittent hiccup or conflict with what's on the raid.
Instead, let's first copy the packages of interest locally. Then we'll use that as our source to point at.
Also, refactor to remove some redundancy.
This should lead to some performance improvement because now we no longer are dependent on constantly asking
dotnetto look at the raid for each sample's build, we just look at the raid once to get what we need and then are local again.